build(editor): drop swift-custom-dump so the editor package's lockfile is toolchain-independent - #2889
Merged
Conversation
… built on resourceURL
…e is toolchain-independent
…kup' into fix/editor-package-lockfile
datlechin
changed the base branch from
main
to
fix/grammars-resource-bundle-lookup
September 15, 2026 07:57
Base automatically changed from
fix/grammars-resource-bundle-lookup
to
main
September 15, 2026 08:06
…ckfile # Conflicts: # LocalPackages/CodeEditSourceEditor/Tests/CodeEditSourceEditorTests/Controller/TextViewController+IndentTests.swift # LocalPackages/CodeEditSourceEditor/Tests/CodeEditSourceEditorTests/Controller/TextViewController+MoveLinesTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2887, which fixes the step ahead of this one. Merging #2887 retargets this to
main.Third thing keeping
main's Package Tests red, behind #2887 and #2888. Once the grammars steppasses, the next one fails:
Cause
swift-custom-dumpdepends on a package that was renamed: older SwiftPM resolves it under theidentity
xctest-dynamic-overlay, newer SwiftPM underswift-issue-reporting. The lockfilerecords whichever identity the toolchain that wrote it chose, and
--force-resolved-versionsthen refuses on the other one. The committed file pins
swift-issue-reporting, which is what acurrent Xcode writes; CI runs Xcode 26.4.1, which wants the old name. Regenerating the file just
moves the failure to whoever runs the other toolchain.
Fix
swift-custom-dumpis a test-only dependency, used forexpectNoDifferencein two files, elevencall sites, every one of them comparing two
Strings.XCTAssertEqualprints both sides of astring mismatch already, so the diff view buys nothing here and the package is paying for two
dependencies and a toolchain-dependent lockfile to get it.
Dropping it takes
swift-custom-dumpandswift-issue-reportingout of the graph, which leavessix pins that every toolchain agrees on.
swift test --package-path LocalPackages/CodeEditSourceEditor --force-resolved-versions:102 Swift Testing cases and 111 XCTest cases (2 skipped), 0 failures.
No CHANGELOG entry: test dependencies are not user-facing.